[Webkit-unassigned] [Bug 87283] [GTK] run-file-chooser signal for WebKit1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87283





--- Comment #2 from Mario Sanchez Prada <msanchez at igalia.com>  2012-05-23 14:05:51 PST ---
(In reply to comment #0)
> [...]
> Adding unit tests looks quite time consuming, and this is my first time
> in the webkit code. I'll try to find some time to work on it soon, but 
> help/direction would be much appreciated.

You basically need to implement a new unit test in Source/WebKit/gtk/tests/testwebview.c, so you actually check that the run-file-chooser gets emitted when clicking on the button and that the new API work as expected in different cases.

For a baseline to start writing a new unit test in that file, I think test_webkit_web_view_fullscreen() could be a good thing to check, as it already connects to some signals in from the WebView and check stuff there.

To get ideas on how to actually implement this specific unit test, which HTML code you could use for testing this new API and so on, you can check testWebViewFileChooserRequest() inside Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp. Implementation of unit tests is slightly different there (as we use a C++ wrapper on top of GTest, instead of using plain C), but the underlying idea is basically the same: connect to the run-file-chooser signal and check different things depending on the HTML used.

Hope this helps, and thanks for your effort on this front.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.