[Webkit-unassigned] [Bug 67093] [Qt] Default window.alert shows HTML entities in certain cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67093


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143208|review?                     |review-
               Flag|                            |




--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2012-05-23 13:03:31 PST ---
(From update of attachment 143208)
I think the patch itself is correct, but there's one little glitch that I think should be fixed before landing. The current order of things is

    setText(msg)
    setTextFormat(Qt::PlainText);

In theory the order of setting properties shouldn't matter, and in fact in terms of correctness it won't make a difference here. But in terms of performance a setText(msg) call with text that contains tags will with QLabel under the hood result in the allocation of a relatively heavy QTextControl instance. If you call setTextFormat(Qt::PlainText) _before_ calling setText, then we can avoid the creation and sub-sequent deletion of the QTextControl inside.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.