[Webkit-unassigned] [Bug 42679] WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 23 11:10:12 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=42679
Dinu Jacob <dinu.jacob at Nokia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dinu.jacob at Nokia.com
--- Comment #6 from Dinu Jacob <dinu.jacob at Nokia.com> 2012-05-23 11:09:16 PST ---
(In reply to comment #5)
> Thanks for the patch Dinu Jacob!
>
> However setUserStyleSheetEnabled seems a good candidate to be added to window.internals.settings (WebCore/testing/InternalSettings) instead of LayoutTestController, because it just sets a property in the page's Settings.
>
> That would avoid the creation of new private C API for the bundle, and possibly remove code from other ports. I did a similar patch for another setting in bug 42689. I am not a reviewer, but my suggestion is you go that route: add it to window.internals.settings.
Yes, it came to me as an after thought :( I will update the patch use Internals.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list