[Webkit-unassigned] [Bug 42679] WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42679


Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cmarcelo at webkit.org,
                   |                            |jesus at webkit.org




--- Comment #5 from Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org>  2012-05-23 06:42:00 PST ---
Thanks for the patch Dinu Jacob!

However setUserStyleSheetEnabled seems a good candidate to be added to window.internals.settings (WebCore/testing/InternalSettings) instead of LayoutTestController, because it just sets a property in the page's Settings.

That would avoid the creation of new private C API for the bundle, and possibly remove code from other ports. I did a similar patch for another setting in bug 42689. I am not a reviewer, but my suggestion is you go that route: add it to window.internals.settings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.