[Webkit-unassigned] [Bug 76362] ASSERT_ICON_SYNC_THREAD fired in WebCore::IconDatabase::iconDatabaseSyncThread()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76362





--- Comment #20 from Sriram Neelakandan <sriram.neelakandan at gmail.com>  2012-05-22 23:33:31 PST ---
(In reply to comment #19)
> (From update of attachment 128380 [details])
What will happen to callers when this returns false?  Do they all do the right thing?

I checked the latest git source as of r118125

We have mixed bag of implementations, but mostly if IconDatabse::open() fails, nothing much is being done !!

Not sure if implementations/users have assumed the API to never fail. 
Should we add some wait and re-open logic inside the API ? 
Note, the failure is still very rare assuming you call open/close in quick successions.

1. WebKit2/UIProcess/WebIconDatabase.cpp:  
   void WebIconDatabase::setDatabasePath(const String &path)
   LOGs and no indication to caller

2. Blackberry
./Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp
bool IconDatabaseClientBlackBerry::initIconDatabase(const BlackBerry::WebKit::WebSettings* settings)                                                                             
 Indicates failure to caller (bool)

3. GTK
./Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp:
void webkit_favicon_database_set_path(WebKitFaviconDatabase* database, const gchar* path)                                                                                        
./Source/WebKit/gtk/webkit/webkiticondatabase.cpp:
void webkit_icon_database_set_path(WebKitIconDatabase* database, const gchar* path)                                                                                              

Both cases no indication to caller

4. Qt
./Source/WebKit/qt/Api/qwebsettings.cpp:
void QWebSettings::setIconDatabasePath(const QString& path)
No indication to caller

5. EFL
./Source/WebKit/efl/ewk/ewk_settings.cpp                  
Eina_Bool ewk_settings_icon_database_path_set(const char* directory)                                                                                                                                                                                                    
No indication to caller

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.