[Webkit-unassigned] [Bug 83865] [EFL] Add Web Inspector to WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83865





--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-22 22:10:42 PST ---
(From update of attachment 138304)
View in context: https://bugs.webkit.org/attachment.cgi?id=138304&action=review

I wonder how many test cases are covered by this patch.

> Source/WebKit/ChangeLog:7
> +        - Add a stub implementation of InspectorClientEfl

Generally, WebKit tends not to use - in ChangeLog.

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:96
> +    InspectorController* controller = ewk_view_core_page_get(m_inspectorView)->inspectorController();

ewk_view_core_page_get() was removed. Use EWKPrivate::corePage()

> Source/WebKit/efl/ewk/ewk_view.h:2446
> +EAPI void ewk_view_web_inspector_show(Evas_Object *o);

It looks it is good to add const keyword as below,

const Evas_Object *o

> Source/WebKit/efl/ewk/ewk_view.h:2453
> +EAPI void ewk_view_web_inspector_close(Evas_Object *o);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.