[Webkit-unassigned] [Bug 87094] GeneratorGeneratedImage should cache images for no pattern draw

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 21:57:52 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87094





--- Comment #12 from Jin Yang <jin.a.yang at intel.com>  2012-05-22 21:56:56 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (From update of attachment 143234 [details] [details])
> > Patch looks OK but please investigate the EWS failures.
> 
> They're all super minor single-digit color deltas.
> 
> Conveniently, I think this patch will also fix https://bugs.webkit.org/show_bug.cgi?id=19942 in a somewhat roundabout way.

I have checked the result, just as you said, they are all super minor single-digit color deltas. I think that's because the former approach draws the gradient on the fly and our patch caches the gradient image first and then tiles the image to destination, this way may lose little pixel precision.

I am not familiar with the rebaseline process. Could you suggest the guide to do rebaseline? Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list