[Webkit-unassigned] [Bug 86557] Allow WebTextFieldDecoratorClient to see applied decorations.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86557





--- Comment #25 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-05-22 20:27:29 PST ---
(In reply to comment #24)
> (From update of attachment 143145 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=143145&action=review
> 
> >>> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:69
> >>> +TextFieldDecorationElement* TextFieldDecorationElement::fromShadowRoot(ShadowRoot* shadowRoot)
> >> 
> >> Can you file a bug about making TextFieldDecorationElement _the_ ShadowRoot and add a FIXME comment referencing it?
> >> 
> >> // FIXME: After fixing http://bugs.webkit.org/...., this should be a simple cast.
> > 
> > How should this be exposed to chromium? Something like 
> > 
> > bool WebTextFieldDecoratorClient::isDefaultVisible()?
> 
> I'm not sure we can make TextFieldDecorationElement a ShadowRoot.
> If we'd like to avoid such digging, we can add id attribute to a TextFieldDecorationElement, and can use ShadowRoot::getElementById().

Well, you're right -- not a Shadow Root. However, it surely does not need to be an element three levels down from the Shadow Root.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.