[Webkit-unassigned] [Bug 86861] Web Inspector: Expose function (closure) scopes in remote protocol

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86861





--- Comment #6 from Peter Rybin <prybin at chromium.org>  2012-05-22 19:51:31 PST ---
> > Source/WebCore/bindings/v8/DebuggerScript.js:70
> > +        return void 0;
> we don't use such notation, simply return here instead.
Done

> > Source/WebCore/bindings/v8/ScriptDebugServer.h:117
> > +// V8-specific interface section.
> You don't need this annotation in the header under bindings/v8. You should also keep this method private to the debug server for the encapsulation purposes.

Yury said you have cross-engine polymorphic interface part and the engine-specific part. Wanted to keep it clear.
Removed now.

> > Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:191
> > +    v8::Handle<v8::Value> scopes = debugServer.callDebuggerMethod("getFunctionScopes", 1, argv);
> Should be debugServer.functionScopes(blah).
Done

> > Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:193
> > +        result->Set(v8::String::New("scopes_raw"), scopes);
> rawScopes ?
Done

> > Source/WebCore/inspector/InjectedScriptHost.cpp:188
> > +    return m_debuggerAgent->scriptDebugServer();
> You should be careful about accessing debugServer before debug domain is enabled and scripts are sent to the front-end. This won't work.

This is still and issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.