[Webkit-unassigned] [Bug 86974] [Qt][Wk2] Assertion failure when selecting an option in select list with size attribute greater than one

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86974





--- Comment #3 from Caio Marcelo de Oliveira Filho <cmarcelo at webkit.org>  2012-05-22 19:11:26 PST ---
(From update of attachment 142925)
View in context: https://bugs.webkit.org/attachment.cgi?id=142925&action=review

Nice catch! Looks good to me, with a comment.

> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:192
> +        emit dataChanged(this->index(oldIndex), this->index(oldIndex));

I think is better to keep the signal emission where it was, after we update the new selected item. This way, if someone reacts to the dataChanged, our model will be in a consistent state.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.