[Webkit-unassigned] [Bug 85118] REGRESSION(r95249): Iframes are printed blank

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85118


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143114|review?                     |review+
               Flag|                            |




--- Comment #54 from Darin Adler <darin at apple.com>  2012-05-22 11:10:14 PST ---
(From update of attachment 143114)
View in context: https://bugs.webkit.org/attachment.cgi?id=143114&action=review

> Source/WebCore/ChangeLog:24
> +        (WebCore):

Please remove non-helpful lines like this from ChangeLog.

> Source/WebCore/ChangeLog:29
> +        (RenderView):

And lines like this.

>> Source/WebCore/page/Frame.cpp:529
>>          view()->forceLayout();
> 
> Just for clarification. For subframes we fall back to view()->forceLayout(); which is almost the same as view()->forceLayoutForPagination but without pagesize restrictions.

If that clarification is needed, then it should probably be in a comment in the code, not just a comment during patch review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.