[Webkit-unassigned] [Bug 86067] [BlackBerry] Possible to clobber httponly cookie.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86067





--- Comment #10 from jochen at chromium.org  2012-05-22 00:55:41 PST ---
(From update of attachment 143215)
View in context: https://bugs.webkit.org/attachment.cgi?id=143215&action=review

> Source/WebCore/platform/blackberry/CookieMap.cpp:57
> +ParsedCookie* CookieMap::addOrReplaceCookie(ParsedCookie* cookie, CookieFilter filter)

I think the semantics that returning cookie means the cookie was not added is very unclear.

Can you make it return a bool indicating whether the cookie was added or not, and add a parameter ParsedCookie** replacedCookie which is set to the replaced cookie if the return value is true?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.