[Webkit-unassigned] [Bug 86844] Web Inspector: "Deactivate All Breapoints" should visually get reflected in Breakpoints pane.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86844


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143185|review?                     |review-
               Flag|                            |




--- Comment #12 from Pavel Feldman <pfeldman at chromium.org>  2012-05-21 22:54:16 PST ---
(From update of attachment 143185)
View in context: https://bugs.webkit.org/attachment.cgi?id=143185&action=review

r- for a tiny error, then it is good to go.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:181
> +        contextMenu.appendItem(breakpointActivationTitle, toggleActiveStateForBreakpoints.bind()); 

You should either bind(this) or not bind at all. In this case, you don't need to bind since you don't access this in the toggle function. You could also do:

var breakpointActive = WebInspector.debuggerModel.breakpointsActive();
var title = WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" : "Activate All Breakpoints");
contextMenu.appendItem(title, WebInspector.debuggerModel.setBreakpointsActive.bind(WebInspector.debuggerModel, !breakpointActive));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.