[Webkit-unassigned] [Bug 87020] run-webkit-tests fails when svn is not installed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 17:05:15 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87020


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #143033|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2012-05-21 17:04:17 PST ---
(From update of attachment 143033)
View in context: https://bugs.webkit.org/attachment.cgi?id=143033&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:97
> +        try:
> +            exit_code = Executive().run_command(svn_info_args, cwd=path, return_exit_code=True)
> +            return (exit_code == 0)
> +        except OSError:
> +            return False

We need a test for this. r- due to the lack of a test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list