[Webkit-unassigned] [Bug 85118] REGRESSION(r95249): Iframes are printed blank

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85118





--- Comment #48 from Vitaly Buka <vitalybuka at chromium.org>  2012-05-21 15:46:41 PST ---
(In reply to comment #47)
> (From update of attachment 142351 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142351&action=review
> 
> >>> Source/WebCore/page/Frame.cpp:525
> >>> +    if (printing && !tree()->parent())
> >> 
> >> Why do we do this for only the root frame?
> > 
> > Added comment to code.
> > I assume that subframes should not be affected directly by page size, only by layout of parent.
> 
> For better or worse, each frame has to lay itself out.  It doesn't really get much from its parent, except a size.  So I suspect this part of the chagne may be wrong.
> 
> When we do layout, it's per-frame.  EAch frame does its own layout.

Actually current ::forceLayoutForPagination mostly different from ::forceLayout just buy size which is calculated from page. So we subfames we fall back to regular ::forceLayout. I don't see problem here. And I didn't found any page that looks incorrect because of that.

Also we have to do something here. Current build just doesn't print iframes at all. So it's signification improvement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.