[Webkit-unassigned] [Bug 86797] results.html should let you rebaseline a test and modify it's listing in test_expectations.txt/Skipped files from the html page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86797





--- Comment #14 from Ojan Vafai <ojan at chromium.org>  2012-05-21 15:46:19 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > I'm confused by how this bug has developed ... we're talking about doing local rebaselines in a checkout, right, not pulling results down from a bot?
> > 
> > Yes.
> > 
> > > can't you already get most of the way there with copying and pasting suppressions into test_expectations.txt and/or re-running NRWT with --reset-results and a list of tests?
> > 
> > Yes, but it's error prone and slow.  More automation here would be better.
> 
> Agreed. Isn't all this basically what Mihai's rebaseline server did? Are we talking about rebuilding that functionality on top of the garden-o-matic code base (I have no objection to doing so, it makes sense, just making sure).

More or less, but with the results.html UI. IMO, this results.html UI plus the functionality provided by garden-o-matic obsoletes the rebaseline server. Would be nice to have one fewer tool to maintain, especially as the rebaseline server is only really useful for really large rebaselines (e.g. bringing up a new port or making a skia change) and learning a new tool for that one use-case just doesn't happen much in practice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.