[Webkit-unassigned] [Bug 87033] New: Geolocation is not robust to unexpected updates from GeolocationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87033

           Summary: Geolocation is not robust to unexpected updates from
                    GeolocationClient
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: steveblock at google.com
                CC: benjamin at webkit.org


Geolocation does not correctly handle updates from the client (via the controller) when they are not expected. For example ...
- A request is made
- Geolocation starts the client
- Permission is denied
- Geolocation invokes the error callback and stops the client, so expects no further updates from the client
- A new request is made
- Geolocation schedules an error callback
- Client makes an unexpected call to Geolocation::positionChanged()
- Geolocation erroneously calls the success callback

This means that tests which manipulate the mock in ways which fall outside of the expected pattern are flaky. For example, permission-denied-already-[error|success].html configure the mock to deny permission, but then later provide a position update.

We should either make Geolocation robust to this case, or update/remove the tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.