[Webkit-unassigned] [Bug 86844] Web Inspector: "Deactivate All Breapoints" should visually get reflected in Breakpoints pane.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86844


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142976|review?                     |review-
               Flag|                            |




--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2012-05-21 09:32:43 PST ---
(From update of attachment 142976)
View in context: https://bugs.webkit.org/attachment.cgi?id=142976&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:141
> +    updateActiveStateForBreakpoints: function()

Breakpoint manager does not have to be involved, just inline it.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:48
> +    this.breakpointActiveState = true;

You should use WebInspector.debuggerModel.breakpointsActive() so that you don't need to keep them in sync.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:177
> +        contextMenu.appendItem(breakpointActivationTitle,this._breakpointManager.updateActiveStateForBreakpoints.bind(this._breakpointManager)); 

" " before "," please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.