[Webkit-unassigned] [Bug 86694] Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86694





--- Comment #7 from Takashi Sakamoto <tasak at google.com>  2012-05-21 00:55:11 PST ---
(In reply to comment #5)
> (From update of attachment 142640 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142640&action=review
> 
> > Source/WebCore/dom/KeyboardEvent.cpp:74
> > +static inline int keyLocationCode(const PlatformKeyboardEvent& key)
> 
> You changed the returned value to int, not to KeyboardEvent::KeyLocationCode. Is there something preventing you from using the latter?

Sorry. I misunderstood your comment. I changed the code to use KeyboardEvent::KeyLocationCode type for returning value type of the function: WebCore::keyLocationCode.

Best regards,
Takashi Sakamoto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.