[Webkit-unassigned] [Bug 86195] [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 00:28:09 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86195





--- Comment #12 from Jussi Kukkonen <jussi.kukkonen at intel.com>  2012-05-21 00:27:14 PST ---
(In reply to comment #10)

Thanks for review Chris & Gyuyoung Kim. I'll fix the string issues.

> > Source/WebKit/efl/ewk/ewk_security_origin.h:99
> > +EAPI uint64_t             ewk_security_origin_web_database_quota_get(const Ewk_Security_Origin *o);
> 
> As far as I know, webkit reviewer don't like to mix patch. You don't mention to fix indentation. I would recommend to file new bug to fix indentation. I think indentation patch is able to be landed without review.

This was not just a random indentation fix: the indentation was fine until I added a function with a long return signature. I can separate the re-indent of course but it seems a little odd to first commit code that makes other code wrongly indented and then fix the indent in another commit...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list