[Webkit-unassigned] [Bug 86067] [BlackBerry] Possible to clobber httponly cookie.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86067





--- Comment #7 from Jason <jason.liu at torchmobile.com.cn>  2012-05-20 19:18:36 PST ---
(In reply to comment #3)
> (From update of attachment 142647 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142647&action=review
> 
> > Source/WebCore/platform/blackberry/CookieManager.h:82
> > +    void setCookies(const KURL&, const String& value, bool isHttpCookie = true);
> 
> Would it be more consistent with the other methods in this class to define an enum instead of using a bool?

(In reply to comment #5)
> (From update of attachment 142647 [details])
> This seems incredibly inefficient. Is this the best we can do?

I thought the cookies are always set by http. And they are seldom set by JavaScript. So I didn't want to add more code into setCookies' deeper code path which may decrease the performance of http cookies.

Maybe above idea is wrong or there is a better method. 
Let me think it over.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.