[Webkit-unassigned] [Bug 73638] [EFL] Implement 'registerProtocolHandler' function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73638





--- Comment #37 from Dongwoo Joshua Im (dwim) <dw.im at samsung.com>  2012-05-20 18:43:05 PST ---
(In reply to comment #36)
> (From update of attachment 142663 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142663&action=review
> 
> Looks almost there to me, there are some minor details left.
> 
> > Source/WebKit/efl/ewk/ewk_view.h:73
> > + *  - "protocolhandler,register", Ewk_Custom_Handler_Data: add a handler url for the given protocol.
> 
> It looks like you forgot to change this to "registered"? You could use another signal name if you think it makes more sense, such as "protocolhandler,registration,requested".
> 

Actually, I didn't want to change the name as 'registered', because of the reason I explained the comment above somewhere.

BTW, your recommendation is pretty nice.
I can use that kind of name for it. ;)

> > Source/WebKit/efl/ewk/ewk_view.h:318
> > +    const char *scheme; /**< Reference to the scheme that will be handled.  (eg. mailto) */
> 
> Nitpick: there are two spaces between '.' and '('. Please enclose "mailto" within quotes.
> 

OK.

> > Source/WebKit/efl/ewk/ewk_view.h:319
> > +    const char *base_url; /**< Reference to the resolved url if the url is relative url. (eg. "https://www.currenthost.com/") */
> 
> Please mention that this member contains an empty string if the URL is not relative.
> 

Do you really think it could have an empty string?
I think it would have a string all the time, even though it could be ignored when the given URL is not relative thing.

I will give you an exact answer after I study about it little bit more.


> > Source/WebKit/efl/ewk/ewk_view.h:321
> > +    const char *title; /**< Reference to the descriptive title of the handler. (eg. Example Email) */
> 
> Nitpick: please enclose "Example Email" withing quotes.

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.