[Webkit-unassigned] [Bug 73638] [EFL] Implement 'registerProtocolHandler' function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73638





--- Comment #36 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-20 15:49:17 PST ---
(From update of attachment 142663)
View in context: https://bugs.webkit.org/attachment.cgi?id=142663&action=review

Looks almost there to me, there are some minor details left.

> Source/WebKit/efl/ewk/ewk_view.h:73
> + *  - "protocolhandler,register", Ewk_Custom_Handler_Data: add a handler url for the given protocol.

It looks like you forgot to change this to "registered"? You could use another signal name if you think it makes more sense, such as "protocolhandler,registration,requested".

> Source/WebKit/efl/ewk/ewk_view.h:318
> +    const char *scheme; /**< Reference to the scheme that will be handled.  (eg. mailto) */

Nitpick: there are two spaces between '.' and '('. Please enclose "mailto" within quotes.

> Source/WebKit/efl/ewk/ewk_view.h:319
> +    const char *base_url; /**< Reference to the resolved url if the url is relative url. (eg. "https://www.currenthost.com/") */

Please mention that this member contains an empty string if the URL is not relative.

> Source/WebKit/efl/ewk/ewk_view.h:321
> +    const char *title; /**< Reference to the descriptive title of the handler. (eg. Example Email) */

Nitpick: please enclose "Example Email" withing quotes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.