[Webkit-unassigned] [Bug 86960] [EFL] Clients should be able to set page cache capacity.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86960





--- Comment #2 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-05-20 14:26:41 PST ---
(From update of attachment 142901)
View in context: https://bugs.webkit.org/attachment.cgi?id=142901&action=review

The addition itself looks fine, but you should mention what the default is. BTW, _ewk_init_body() calls setCapacity() directly, you might want to route that call via ewk_settings now.

> Source/WebKit/efl/ChangeLog:9
> +        Those will be used both by clients ant DRT Layout Test Controller.

Nitpick: s/ant/and/.

> Source/WebKit/efl/ewk/ewk_settings.h:302
> + * The page cache improves user experience when navigating forth or back
> + * to pages in the forward/back history.

It'd be good to describe how it achieves this improvement: what does it cache, for example?

> Source/WebKit/efl/ewk/ewk_settings.h:306
> +EAPI unsigned         ewk_settings_page_cache_capacity_get();

This is a public header used by C applications, so you need to use foo(void) instead of foo().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.