[Webkit-unassigned] [Bug 65834] NRWT should support cascading expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65834


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |dpranke at chromium.org
                   |kit.org                     |
                 CC|                            |epoger at chromium.org




--- Comment #22 from Dirk Pranke <dpranke at chromium.org>  2012-05-18 15:46:42 PST ---
I'm working on this now ... the basic plan will be as follows:

cascading expectations will be an extension of the existing "overrides" mechanism. In other words, each port will have an ordered list of expectations files. If two files have an entry for the same test, the later entry will override the earlier one. If a later file has an entry for a directory that contains tests with entries in earlier files, those earlier entries will also be overridden (this will be different from how overrides currently work). This will allow later files to have full control over any and all suppressions.

Initially, all files in the list will be required to have support the same list of platform/configuration modifiers. If need arises, we can work out a scheme by which different files can support different modifiers and/or have certain configurations "defaulted in".

Skipped lists will be converted on-the-fly to expectations files and then appended. This means that tests listed in *any* Skipped file will override all entries in expectations files.

Any tests disabled by compile-time or runtime flags will then be appended as expectations; this will also override any expectations entries.

Finally, the command line flags --additional-expectations and --ignore-tests will be treated as if they were appended to the ordered list above, again giving the user full control over all of the expectations, allowing for local expectations on a machine, etc.

--lint-test-files diagnostics will be improved to report which files each expectation shows up in, and when expectations are redundant.

The basic implementation approach will be

1) rework the existing TestExpectations class interfaces a bit to make it easier to support the next sets of changes

2) add better diagnostics to --lint-test-files

3) update the existing code to remove the "overrides" concept and just pass the ordered lists around. "Skipped" lists

4) profit ... I mean, let each port decide if and how they want to use cascaded files and when they want to drop the Skipped files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.