[Webkit-unassigned] [Bug 86694] Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86694


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142640|review?                     |review+
               Flag|                            |




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2012-05-18 10:10:02 PST ---
(From update of attachment 142640)
View in context: https://bugs.webkit.org/attachment.cgi?id=142640&action=review

> Source/WebCore/dom/KeyboardEvent.cpp:74
> +static inline int keyLocationCode(const PlatformKeyboardEvent& key)

You changed the returned value to int, not to KeyboardEvent::KeyLocationCode. Is there something preventing you from using the latter?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.