[Webkit-unassigned] [Bug 86796] Change a bunch of things in the test_expectations.txt format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86796





--- Comment #9 from Tony Chang <tony at chromium.org>  2012-05-18 09:49:24 PST ---
(In reply to comment #8)
> (In reply to comment #3)
> > > For the record, though ...
> > > > 
> > > > 1. Make SLOW, SKIP and WONTFIX outcomes instead of modifiers.
> > > 
> > > Does SLOW imply PASS? We certainly have slow failures today, and if it doesn't imply pass, but only keeps its current semantics, it seems like it complicates the implementation (SLOW is now "special"). We could also just get rid of SLOW.
> > 
> > Yes. Slow needs to imply pass, unless you explicitly list another expected outcome as well. So, SLOW=>PASS, "SLOW TEXT"=>TEXT, "SLOW TEXT PASS"=>"TEXT PASS".
> > 
> > Specifically "SLOW TEXT" does not imply "SLOW PASS TEXT".
> > 
> > Personally, I prefer killing SLOW, but this has been controversial in the past and we've already had enough bikeshedding. :)
> > 
> 
> Hm. I'm strongly tempted to kill SLOW instead of implement this :).

Please don't mix syntax changes with functionality changes in the same patch. If we want to change the meaning of anything, that should be in an isolated patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.