[Webkit-unassigned] [Bug 86843] [GTK] Add GCancellable parameter to all methods using gio async pattern

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86843





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-05-18 08:53:08 PST ---
(In reply to comment #3)
> (From update of attachment 142688 [details])
> The patch looks fine to me, but I am curious about the motivation.

Mainly consistency, cancellable is something expected in functions using the gio async model.

> What does cancellation support really gain us in these cases? It looks like the only practical gain would be it would be possible to get a "cancelled" error after the async request is finished, since we are not checking for cancellation anywhere else that would avoid continued processing.

Other methods follow the approach of async method + signals, for example, cancelling a download operation emits the error signal with cancelled error. And we have specific APIs for it webkit_download_cancel. Something similar happens when loadingf something in a web view (load error signal + stop_load method). 

For methods using the gio async model, we provide the standard way, a cancellable object that allow the user to cancel the operation (and from any thread). When the user finishes the operation CANCELLED error is returned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.