[Webkit-unassigned] [Bug 86844] Web Inspector: "Deactivate All Breapoints" should visually get reflected in Breakpoints pane.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86844





--- Comment #5 from sam <dsam2912 at gmail.com>  2012-05-18 05:52:51 PST ---
(In reply to comment #4)
> View in context: https://bugs.webkit.org/attachment.cgi?id=142691&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Breakpoints-pane as well
> 
> nit: we usually spell panes, like "the Breakpoints pane", without dashes. The entire description can also fit a single line (WebKit has no limitations on the line length, except the programmer's reason.)
oh ok, I will change it. Thank you.
> 
> > Source/WebCore/inspector/front-end/inspector.css:2142
> > +.breakpoints-list-deactivated {
> 
> You could have used the selector of ".breakpoints-deactivated .breakpoint-list" and avoid having to modify ScriptsPanel.js

Ya, I had earlier thought of the same thing but this would also affect DOM Breakpoint pane having same .breakpoint-list class. But I guess currently "Deactivate All Breakpoints" is only applicable on JS breakpoints.
So this would give a false impression of DOM breakpoints being deactivated, which is currently not the case. Your thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.