[Webkit-unassigned] [Bug 86823] [GTK] Allow to attach/detach the inspector in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86823


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142667|review?                     |review+
               Flag|                            |




--- Comment #3 from Gustavo Noronha (kov) <gns at gnome.org>  2012-05-18 05:49:08 PST ---
(From update of attachment 142667)
View in context: https://bugs.webkit.org/attachment.cgi?id=142667&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:438
> -    return FALSE;
> +    return TRUE;

These look like a somewhat unrelated fix. In the interest of better bisectability, can you land these three in a separate commit? rs=me on doing that

> Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp:156
> +    // This method is called to decide whether to attach the inspector or not depending on whether
> +    // the inspector view fits into the window. Attach is implemented by the client, so return 0
> +    // when the client doesn't implement attach, to make sure the inspector is never attached.

I don't understand this comment, who would return 0 here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.