[Webkit-unassigned] [Bug 85369] [EFL] PlatformKeyboardEventEfl implementation fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85369


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142660|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-05-18 02:58:58 PST ---
(From update of attachment 142660)
View in context: https://bugs.webkit.org/attachment.cgi?id=142660&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] PlatformKeyboardEventEfl implementation fix

This patch implements new functionality, fix potential bug and refactoring code. Please do not mix multiple patches into a patch.

> Source/WebCore/platform/efl/EflKeyboardUtilities.cpp:228
> +        return "\x1b";

To be consistent with other condition, let's use String("").

> Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp:444
> +    // From GTK. Don't allow text insertion for nodes that cannot edit.

It looks this condition is clear. So, it seems to me "From GTK" is not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.