[Webkit-unassigned] [Bug 84251] [shadow] needs style recalculation by changing applyAuthorStyles dynamically

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84251





--- Comment #4 from Takashi Sakamoto <tasak at google.com>  2012-05-18 01:35:09 PST ---
(In reply to comment #2)
> (From update of attachment 141647 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141647&action=review
> 
> In addition to reftests, It would be desired to check style value using widow.getComputedStyle()
> before and after the second change. That allows you to ensure that the value is actually changed dynamically.
> 
> > Source/WebCore/dom/ShadowRoot.cpp:201
> > +            owner()->needsStyleRecalc();
> 
> needsStyleRecalc() doesn't have any side effect.
> It looks what you want is setNeedsReattachHostChildrenAndShadow().

Done.

> > LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:94
> > +    shadowRoot.applyAuthorStyles = true;
> 
> You need to force layout here (using offsetLeft or getComputedStyle like thing)
> 
> > LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:108
> > +    shadowRoot.applyAuthorStyles = false;
> 
> Ditto.

I see. I added "div.offsetLeft".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.