[Webkit-unassigned] [Bug 86796] Change a bunch of things in the test_expectations.txt format

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 19:54:44 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86796





--- Comment #6 from Ojan Vafai <ojan at chromium.org>  2012-05-17 19:53:48 PST ---
(In reply to comment #4)
> Here are some variants (with blackslash included):
> 
> webkit.org/12345 WIN MAC DEBUG \ animations/stop-animation-on-suspend.html \ CRASH TEXT PASS
> webkit.org/12345 WIN MAC DEBUG [ animations/stop-animation-on-suspend.html ] CRASH TEXT PASS
> webkit.org/12345 WIN MAC DEBUG : animations/stop-animation-on-suspend.html : CRASH TEXT PASS
> webkit.org/12345 WIN MAC DEBUG ; animations/stop-animation-on-suspend.html ; CRASH TEXT PASS
> webkit.org/12345 WIN MAC DEBUG = animations/stop-animation-on-suspend.html = CRASH TEXT PASS
> webkit.org/12345 WIN MAC DEBUG - animations/stop-animation-on-suspend.html - CRASH TEXT PASS
> webkit.org/12345 WIN MAC DEBUG , animations/stop-animation-on-suspend.html , CRASH TEXT PASS
> webkit.org/12345 WIN MAC DEBUG . animations/stop-animation-on-suspend.html . CRASH TEXT PASS
> 
> I kind of dig backslash and square bracket versions. Those two separates tokens visually very well.

My vote would be backslash, but I declare bikeshed bankruptcy and will go along with any delimiter we choose.

(In reply to comment #5)
> By the way, if we already have 2 delimiters, then why not 3 as in?
> 
> webkit.org/12345 \ WIN MAC DEBUG \ animations/stop-animation-on-suspend.html \ CRASH TEXT PASS
> 
> Since there are logically 4 separate sections in this line.

I don't find I need the extra slash to easily visually delimit the bug number since it is pretty much always the first thing on the line and there are rarely two bugs for a given line. While I agree that this is the logical extension of separating each group, it seems like unnecessary overkill to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list