[Webkit-unassigned] [Bug 86796] Change a bunch of things in the test_expectations.txt format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86796





--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2012-05-17 19:45:03 PST ---
(In reply to comment #1)
> (In reply to comment #0)
> > As per the result of https://lists.webkit.org/pipermail/webkit-dev/2012-May/020674.html, we've agree to make the following changes to the test_expectations.txt format.
> 
> Not to be a huge pain, but I'm not sure that there was "agreement" on this; I'd kinda like to see Maciej and/or Darin weigh in.

Meh. I think if anyone were to object, they would have done so by now.

> For the record, though ...
> > 
> > 1. Make SLOW, SKIP and WONTFIX outcomes instead of modifiers.
> 
> Does SLOW imply PASS? We certainly have slow failures today, and if it doesn't imply pass, but only keeps its current semantics, it seems like it complicates the implementation (SLOW is now "special"). We could also just get rid of SLOW.

Yes. Slow needs to imply pass, unless you explicitly list another expected outcome as well. So, SLOW=>PASS, "SLOW TEXT"=>TEXT, "SLOW TEXT PASS"=>"TEXT PASS".

Specifically "SLOW TEXT" does not imply "SLOW PASS TEXT".

Personally, I prefer killing SLOW, but this has been controversial in the past and we've already had enough bikeshedding. :)

> > 4. WONTFIX tests are either skipped or we ignore their output as long as they don't crash (slight preference for skipping them, but not enough to argue over it).
> 
> We should skip the WONTFIX tests. I don't think we should ignore output if we're going to run tests. 

Works for me.

> > 5. Use the same character as a separator before and after the test (":").
> 
> I'm not sure this is an improvement. If we were going to standardize on the same delimiter I would be open to using one that doesn't require a shift key as per request from rniwa. Possible candidates: "-", ";", ",", "=" (which I would prefer in that order, I think; frankly, I only really like "-" here, and I'm not sure I like any of them more than the existing ":"/"=" combo).

I don't really care what we use. Semi-colon seems fine to me. I've just seen it be a source of confusion that there are two different delimiters. 

> > Anyone feel moved to make these changes?
> 
> I woud be happy to do some or all of the changes once the dust settles on this debate.

Great. Thanks! I'm happy to do reviews for this stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.