[Webkit-unassigned] [Bug 86796] Change a bunch of things in the test_expectations.txt format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86796


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com,
                   |                            |mjs at apple.com




--- Comment #1 from Dirk Pranke <dpranke at chromium.org>  2012-05-17 19:29:04 PST ---
(In reply to comment #0)
> As per the result of https://lists.webkit.org/pipermail/webkit-dev/2012-May/020674.html, we've agree to make the following changes to the test_expectations.txt format.

Not to be a huge pain, but I'm not sure that there was "agreement" on this; I'd kinda like to see Maciej and/or Darin weigh in.

For the record, though ...
> 
> 1. Make SLOW, SKIP and WONTFIX outcomes instead of modifiers.

Does SLOW imply PASS? We certainly have slow failures today, and if it doesn't imply pass, but only keeps its current semantics, it seems like it complicates the implementation (SLOW is now "special"). We could also just get rid of SLOW.

> 4. WONTFIX tests are either skipped or we ignore their output as long as they don't crash (slight preference for skipping them, but not enough to argue over it).

We should skip the WONTFIX tests. I don't think we should ignore output if we're going to run tests. 

> 2. Change bug modifiers to be URLs. The format for person bugs is bug(ojan).

I'm fine w/ this.

> 3. The only things that come before the test are bug modifiers and platform/configuration modifiers (e.g. MAC DEBUG).

I'm fine w/ this (although unclear about if this is true depending on how we deal w/ SLOW).

> 5. Use the same character as a separator before and after the test (":").

I'm not sure this is an improvement. If we were going to standardize on the same delimiter I would be open to using one that doesn't require a shift key as per request from rniwa. Possible candidates: "-", ";", ",", "=" (which I would prefer in that order, I think; frankly, I only really like "-" here, and I'm not sure I like any of them more than the existing ":"/"=" combo).

> 6. Standardize both Skipped and test_expectations.txt on a common comment delimiter (i.e. "#").

Fine w/ this one. I have no preference between "#" and "//".

> Anyone feel moved to make these changes?

I woud be happy to do some or all of the changes once the dust settles on this debate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.