[Webkit-unassigned] [Bug 86769] mediaControls()->playbackStarted() may be called more than once

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 16:17:52 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86769


Max Feil <mfeil at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|HTML5 video controls are    |mediaControls()->playbackSt
                   |not automatically fading    |arted() may be called more
                   |out when fullscreen         |than once




--- Comment #9 from Max Feil <mfeil at rim.com>  2012-05-17 16:16:57 PST ---
(In reply to comment #8)
> This is a good fix, but I think you may be fixing the symptom of a larger issue.  And perhaps we should make explicit the expectation that mediaPlayerTimeChanged() is only called during scrubbing / seeking.

Ah, yes. I see what you mean. I was not aware until now that mediaPlayerTimeChanged() needs to be called to indicate the end of seeking. I made sure this happens now in the BlackBerry platform media player code, and the playbackProgressTimer works reliably.

I've stopped calling mediaPlayerTimeChanged() unnecessarily, and the patch attached to this PR is no longer needed. Or at least not needed to fix any perceptible problem. I'll have a hard time coming up with an automated test now ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list