[Webkit-unassigned] [Bug 71271] [Qt] Web Inspector: local inspector client UI becomes unresponsive on debugger pause during

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71271





--- Comment #22 from Zalan Bujtas <zbujtas at gmail.com>  2012-05-17 01:59:39 PST ---
(From update of attachment 142441)
View in context: https://bugs.webkit.org/attachment.cgi?id=142441&action=review

Good catch! However you are missing changelog entry. Please look at the following page http://www.webkit.org/coding/contributing.html and submit your patch accordingly.

> Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:67
> +        // This leads that Web Inspector front-end is paused too leading to locked Web Inspector GUI (bugzilla ticket 71271).

No need to mention the bug# in the comment. Changelog entry should have it.

> Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:68
> +        handle()->page->setGroupName("__WebInspectorPageGroup__");

I'd rather have it in InspectorClient::openInspectorFrontend() where we actually open the front end, something like m_frontendWebPage->setGroupName("group_name_comes_here");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.