[Webkit-unassigned] [Bug 86591] [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86591





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2012-05-16 23:16:40 PST ---
(From update of attachment 142413)
View in context: https://bugs.webkit.org/attachment.cgi?id=142413&action=review

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:704
> +    // This prevents erasing spelling markers on OS X Lion or later to match AppKit on these Mac OS X versions.
> +#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
> +    return type != TextCheckingTypeSpelling;
> +#else
> +    return true;
> +#endif

On my second thought, it's not great that this code is duplicated in WebKit and WebKit2. Is there any way to share this code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.