[Webkit-unassigned] [Bug 86690] Rename test_expectations.txt to TestExpectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86690





--- Comment #9 from Dirk Pranke <dpranke at chromium.org>  2012-05-16 22:30:46 PST ---
(In reply to comment #7)
> (In reply to comment #1)
> > Other naming ideas:
> > 
> > * Expectations
> > * ExpectedResults
> > * CurrentResults
> > 
> > I'm tempted by the last one because it avoids the confusing between this file and the -expected.txt files.
> 
> I like CurrentResults for the same reason as Adam.

Is the confusion you're seeking to avoid the use of "expect" in both names? Or is it that "test expectations" sounds too much like "text expectation"? Can someone use these names in an example sentence or two to better illustrate the confusion? 

For example, I often ask someone "what's in the test expectations" or say "I will add that to the expectations file"; it seems like the meaning of both of those is reasonably clear, but I could see how the first one could be misheard.

Maybe something like "suppressions" is better, since we often talk about suppressing an error?

On a different note, I would like to note that there is a clear connection between the name of the file and the name of the classes that process the file in the code today (e.g., TestExpectaions{Parser,Serializer,Model}). If we change the one, we should probably change the others as well. To that end, I am somewhat leery of "result" insofar as that is already badly overloaded in the NRWT code (e.g., TestResult, ResultSummary).

(In reply to comment #8)
> (In reply to comment #3)
> > Unless someone comes up with something massively better than what we have now this seems like semi-pointless bikeshedding.
> 
> As a counterpoint: WebKit has a long tradition of renaming and moving things for clarity and consistency. We try not to rename things willy-nilly but nearly every file in the project has been renamed at least once and has moved places in the directory structure at least twice. If we find a name that is genuinely better, we should try not to be held back by inertia alone. That is the WebKit Way as I understand it.

Sure, I agree with that. I think it's all in how one defines "genuinely" (or "massively") better (and willy-nilly, for that matter).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.