[Webkit-unassigned] [Bug 86691] Simplify syntax in test_expectations.txt

Wed May 16 17:16:40 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=86691

--- Comment #5 from Ojan Vafai <ojan at chromium.org>  2012-05-16 17:15:40 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > I'm OK with making these changes. Outside of the bug number changes I'm not convinced it's actually an improvement.
> 
> I've found many people adding entries without : and = and cause test failures :(
> 
> > If we do make these changes, then I think we should make it so that the expected result of the test is optional. For example:
> > foo/bar.html 12345
> > foo/bar.html SLOW
> 
> Shouldn't "foo/bar.html 12345" do the same thing as SKIP? Why do we ever want to list a test there if we're expecting it to pass everywhere?

It's a way of associating a test with a bug. We can use this for cases where we check in the failing result as a way of keeping track of the regression so that it gets fixed eventually.

The bigger problem with implying SKIP, is how do you decide when SKIP isn't applied? That needs some hidden set of rules that's too complicated IMO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.