[Webkit-unassigned] [Bug 85118] REGRESSION(r95249): Iframes are printed blank

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85118





--- Comment #40 from Vitaly Buka <vitalybuka at chromium.org>  2012-05-16 14:25:04 PST ---
(In reply to comment #38)
> (From update of attachment 141562 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=141562&action=review
> 
> Fix looks good but I have one question. I won’t say review- because I’m not certain the code is wrong.
> 
> > Source/WebCore/page/FrameView.cpp:3253
> > -        if (docLogicalWidth > pageLogicalWidth) {
> > +        if (!pageSize.isZero() && docLogicalWidth > pageLogicalWidth) {
> 
> I still don’t understand why we are in this function at all for a frame that is not the main frame. If the caller is passing a size of zero then it shouldn’t even be calling the forceLayoutForPagination function in the first place. How does this happen in practice?

You right. We can avoid this call.
Fixed.
Please review again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.