[Webkit-unassigned] [Bug 86483] LayerAnimation is not thread safe, which makes dereferencing an expensive operation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 11:19:43 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=86483





--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2012-05-16 11:18:47 PST ---
(From update of attachment 141984)
View in context: https://bugs.webkit.org/attachment.cgi?id=141984&action=review

> Source/WebCore/platform/graphics/blackberry/LayerAnimation.h:63
> +        if (m_name.isEmpty())
> +            return String("");
> +        return String(m_name);

What's the purpose of this change? All empty strings share the same StringImpl anyway. Constructing a copy of a string doesn't do anything useful for thread safety either.

Please use ChangeLog to explain changes for each function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list