[Webkit-unassigned] [Bug 86498] [EFL][DRT] LayoutTestController does not implement originsWithApplicationCache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86498





--- Comment #4 from Jussi Kukkonen <jussi.kukkonen at intel.com>  2012-05-16 03:36:23 PST ---
(In reply to comment #2)
> (From update of attachment 142186 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142186&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:44
> > +#include <JavaScriptCore/JSRetainPtr.h>
> 
> probably not needed
> 
> > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:757
> > +        JSRetainPtr<JSStringRef> originJS(Adopt, JSStringCreateWithUTF8CString(it->get()->databaseIdentifier().utf8().data()));
> 
> JSStringRef originJS = JSStringCreateWithUTF8CString(it->get()->databaseIdentifier().utf8().data());
> 
> > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:758
> > +        jsOriginsArray[i++] = JSValueMakeString(context, originJS.get());
> 
> jsOriginsArray[i++] = JSValueMakeString(context, originJS);


Thanks. This makes all kinds of sense.

> > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:110
> > +
> 
> Unneeded blank line

The previous block is commented "// TextInputController", didn't want to lead the reader into any conclusions about the new function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.