[Webkit-unassigned] [Bug 86498] [EFL][DRT] LayoutTestController does not implement originsWithApplicationCache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86498





--- Comment #2 from Christophe Dumez <christophe.dumez at intel.com>  2012-05-16 03:02:20 PST ---
(From update of attachment 142186)
View in context: https://bugs.webkit.org/attachment.cgi?id=142186&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:44
> +#include <JavaScriptCore/JSRetainPtr.h>

probably not needed

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:757
> +        JSRetainPtr<JSStringRef> originJS(Adopt, JSStringCreateWithUTF8CString(it->get()->databaseIdentifier().utf8().data()));

JSStringRef originJS = JSStringCreateWithUTF8CString(it->get()->databaseIdentifier().utf8().data());

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:758
> +        jsOriginsArray[i++] = JSValueMakeString(context, originJS.get());

jsOriginsArray[i++] = JSValueMakeString(context, originJS);

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:110
> +

Unneeded blank line

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.