[Webkit-unassigned] [Bug 84251] [shadow] needs style recalculation by changing applyAuthorStyles dynamically

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 22:23:23 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84251


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #141647|review?                     |review-
               Flag|                            |




--- Comment #2 from Hajime Morrita <morrita at google.com>  2012-05-15 22:22:28 PST ---
(From update of attachment 141647)
View in context: https://bugs.webkit.org/attachment.cgi?id=141647&action=review

In addition to reftests, It would be desired to check style value using widow.getComputedStyle()
before and after the second change. That allows you to ensure that the value is actually changed dynamically.

> Source/WebCore/dom/ShadowRoot.cpp:201
> +            owner()->needsStyleRecalc();

needsStyleRecalc() doesn't have any side effect.
It looks what you want is setNeedsReattachHostChildrenAndShadow().

> LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:94
> +    shadowRoot.applyAuthorStyles = true;

You need to force layout here (using offsetLeft or getComputedStyle like thing)

> LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:108
> +    shadowRoot.applyAuthorStyles = false;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list