[Webkit-unassigned] [Bug 86565] [chromium] run-webkit-tests can't be work in ubuntu 12.04

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86565





--- Comment #2 from Kent Tamura <tkent at chromium.org>  2012-05-15 20:49:21 PST ---
(From update of attachment 142136)
View in context: https://bugs.webkit.org/attachment.cgi?id=142136&action=review

> Tools/DumpRenderTree/chromium/TestShellLinux.cpp:174
> +            if (!strcmp(fonts[i], "/usr/share/fonts/truetype/thai/Garuda.ttf")) {
> +                // ttf-thai-tlwg package uses different path in Ubuntu 12.04.
> +                static const char* tlwg = "/usr/share/fonts/truetype/tlwg/Garuda.ttf";
> +                if (access(tlwg, R_OK)) {
> +                    fprintf(stderr, "You are missing %s or %s. Try re-running build/install-build-deps.sh. Also see "
> +                                    "http://code.google.com/p/chromium/wiki/LayoutTestsLinux",
> +                                    fonts[i], tlwg);
> +                    exit(1);
> +                }
> +            } else {
> +                fprintf(stderr, "You are missing %s. Try re-running build/install-build-deps.sh. Also see "
>                              "http://code.google.com/p/chromium/wiki/LayoutTestsLinux",
>                              fonts[i]);
> -            exit(1);
> +                exit(1);
> +            }
>          }

I'd like:
 - removing Garuda.ttf from 'fonts' array
 - introduce new function to take two arguments for paths (tahi/Garuda.ttf and tlwg/Garuda.ttf). The function checks their existence and calls FcConfigAppFontAddFile().

The following check for lohit_pa.ttf might use the function too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.