[Webkit-unassigned] [Bug 73638] [EFL] Implement 'registerProtocolHandler' function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73638





--- Comment #34 from Dongwoo Joshua Im (dwim) <dw.im at samsung.com>  2012-05-15 19:54:56 PST ---
(In reply to comment #32)
> Now on to the rest.
> 
> (In reply to comment #29)
> > (In reply to comment #27)
> > > > Source/WebKit/efl/ewk/ewk_view.h:317
> > > > +    const char *target; /**< Reference to the protocols that will be handled.  (eg. mailto, irc) */
> > > Isn't this a single protocol instead of protocols (plural)? Shouldn't the variable be just called "protocol"?
> > 1. Single protocol. I will remove one of them.
> > 2. I use the name "target" because I want to use this attribute for both protocol and content.
> >   I will change the name of this attribute as protocol, 
> >   and I will re-change it when I add Content Handler.
> 
> In the end you chose to use "scheme" as the variable name, which is OK, but you still say "protocols" (plural) in the documentation.
>

Oh. I will use 'scheme' in the comment. That will be better. Thanks!


> > > > Source/WebKit/efl/ewk/ewk_view.h:318
> > > > +    const char *base_url; /**< Reference to the resolved url if the url is relative url. (eg. "https://www.currenthost.com/") */
> > > If the URL isn't relative, is this 0 or an empty string?
> > This is the return value of Document::baseURL().
> > This has value whether the url is relative or not.
> 
> This does not answer my question -- I am asking if the value of this variable will be 0 (NULL) or an empty, allocated string if the URL is not relative. This should be properly documented.

I don't think this could be empty when any web page is loaded.
This attribute set by Document::setURL function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.