[Webkit-unassigned] [Bug 86436] shrinkToFit() is often not called for Vectors in CodeBlock

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86436





--- Comment #7 from Filip Pizlo <fpizlo at apple.com>  2012-05-15 14:50:00 PST ---
(In reply to comment #6)
> (From update of attachment 142062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=142062&action=review
> 
> > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2130
> >          m_rareData->m_lineInfo.shrinkToFit();
> 
> I think we always have line info now -- it seems we should pull it out of rareData so we're not unnecessarily creating what is intended to be an uncommon allocation.
> 
> > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2136
> > +        m_rareData->m_callReturnIndexVector.shrinkToFit();
> > +#endif
> > +#if ENABLE(DFG_JIT)
> > +        m_rareData->m_inlineCallFrames.shrinkToFit();
> > +        m_rareData->m_codeOrigins.shrinkToFit();
> 
> Ditto for these -- do we want a lazily instantiated m_jitData member perhaps?

Separate patch for both?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.