[Webkit-unassigned] [Bug 86129] [BlackBerry] Enable the Fullscreen API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86129





--- Comment #18 from Jer Noble <jer.noble at apple.com>  2012-05-15 08:57:42 PST ---
(From update of attachment 141483)
View in context: https://bugs.webkit.org/attachment.cgi?id=141483&action=review

>> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:127
>>  MediaPlayerPrivate::~MediaPlayerPrivate()
>>  {
>>      if (isFullscreen()) {
>> -        HTMLMediaElement* element = static_cast<HTMLMediaElement*>(m_webCorePlayer->mediaPlayerClient());
>> -        element->exitFullscreen();
>> +        if (HTMLMediaElement* element = static_cast<HTMLMediaElement*>(m_webCorePlayer->mediaPlayerClient()))
>> +            element->exitFullscreen();
> 
> I still think it would have to be done on a separate patch. Jer?

I agree.  A testcase would be helpful as well.  Also, I realize this code was already here, but since you're in here... :)

If you need to pass a message up to the HTMLMediaElement, Instead of casting the client pointer to an HTMLMediaElement, you should define a new pure virtual function of MediaPlayerClient, like:

virtual void mediaPlayerExitFullscreen() = 0;

...And override it in HTMLMediaElement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.