[Webkit-unassigned] [Bug 86367] Web Inspector: Use CSS columns feature for HelpScreen contents.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=86367





--- Comment #23 from eustas.bug at gmail.com  2012-05-15 07:19:50 PST ---
(From update of attachment 141924)
View in context: https://bugs.webkit.org/attachment.cgi?id=141924&action=review

>> Source/WebCore/inspector/front-end/SettingsScreen.js:51
>> +    var appendSection = function(name) {
> 
> why not just function appendSection(name)?

I've done so to make it more uniform with:
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Function_Declarations_Within_Blocks#Function_Declarations_Within_Blocks

Fixed.

>> Source/WebCore/inspector/front-end/ShortcutsScreen.js:81
>> +            orderedSections[i].renderSection(container.createChild("div", "help-block"));
> 
> So we have one help-block per section. Can this be moved into renderSection() then? If so, I would also consider orderedSections.forEach(renderSection, this)

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.